goankur commented on PR #16628: URL: https://github.com/apache/lucene/pull/16628#issuecomment-5806228019
@Pulkitg64 heads up — #16705 changes `KnnVectorValues#prefetch` so that `prefetch(int ord, int count)` is the primitive and the `int[]` form coalesces consecutive ordinals over it. That touches `OffHeapFloat16VectorValues`, `RescoreTopNQuery`, `FullPrecisionFloatVectorSimilarityValuesSource` and `TestOffHeapVectorValues`, which this PR also changes. Whichever lands second will need a small rebase. If #16705 goes first, the array-form `prefetch` override this PR adds to `OffHeapFloat16VectorValues` collapses into the inherited coalescing implementation, so it would be strictly less code — happy to do that rebase for you. Ordering the other way works too, I would just forward `prefetch(int ord, int count)` from the fp16 wrapper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
