msokolov commented on PR #15584:
URL: https://github.com/apache/lucene/pull/15584#issuecomment-4298988941
I tried switching over to use `IndexOptions` but I found that the existing
options are cumulative, so this model might not work without some significant
overhaul. For example, in `FreqProxTermsWriterPerField` we have this logic:
```
hasFreq = indexOptions.compareTo(IndexOptions.DOCS_AND_FREQS) >= 0;
hasProx =
indexOptions.compareTo(IndexOptions.DOCS_AND_FREQS_AND_POSITIONS) >= 0;
hasOffsets =
indexOptions.compareTo(IndexOptions.DOCS_AND_FREQS_AND_POSITIONS_AND_OFFSETS)
>= 0;
```
That seems easy enough to fix, but it makes me worry there could be other
similar gotchas. Does anybody know what to expect? @rmuir , @mikemccand ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
