kotman12 commented on code in PR #14885:
URL: https://github.com/apache/lucene/pull/14885#discussion_r2280585251
##########
lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java:
##########
@@ -85,6 +85,13 @@ public Collection<Query> getDisjuncts() {
return Collections.unmodifiableCollection(disjuncts);
}
+ /**
+ * @return the disjuncts in the same order as the input Query collection.
+ */
+ public Collection<Query> getDisjunctsInOriginalOrder() {
Review Comment:
Thanks for the feedback! I think I addressed your comments with the latest
commit by removing this method and adding a check to the renamed
`testCasesWhenDisjunctOrderMatters`. I've also beefed up `TestQueryDecomposer`
to validate order since the `QueryDecomposer` is especially sensitive to this
behavior. In theory you could also make sure any Query parsers we know about
don't break this upstream of the Disjunction/BooleanQueries but in practice
this is not maintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
