kaivalnp commented on PR #14843:
URL: https://github.com/apache/lucene/pull/14843#issuecomment-3060745112
Thanks a lot for the review @uschindler, it was super helpful!
I've taken an initial pass at refactoring some classes in `main` to make
this backport easier like you mentioned (#14934)
I've segregated all "unsafe" code outside
`FaissKnnVectors{Format/Reader/Writer}`, which is also loaded dynamically to
make backport easier (we can directly move those files to `java21/` on 10.x)
Would appreciate a review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
