bjacobowitz commented on issue #14886: URL: https://github.com/apache/lucene/issues/14886#issuecomment-3045857506
A couple side notes: Just to call it out explicitly from @kotman12 's earlier [comment](https://github.com/apache/lucene/issues/14886#issuecomment-3036969030), `BytesRef`'s hashCode uses [StringHelper.GOOD_FAST_HASH_SEED](https://github.com/apache/lucene/blob/c30f23a082c1880754143b0382e16e1f0e1d99b3/lucene/core/src/java/org/apache/lucene/util/StringHelper.java#L132-L150) (which might as well be random), and `GOOD_FAST_HASH_SEED` has a comment indicating that one of its intended purposes is to catch places where we are somehow relying on hash order. So I'm in favor of the proposed fix in the PR. If I've understood correctly, if the query being decomposed is rooted with a conjunction (e.g. `"field1:baz AND (field2:foo OR field3:bar)"`), it looks like this issue wouldn't arise, because the decomposition would see multiple mandatory clauses and stop decomposing ([see here](https://github.com/apache/lucene/blob/c30f23a082c1880754143b0382e16e1f0e1d99b3/lucene/monitor/src/java/org/apache/lucene/monitor/QueryDecomposer.java#L95)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
