iverase opened a new pull request, #14340:
URL: https://github.com/apache/lucene/pull/14340
Lucene90DocValuesProducer holds all the metadata found on the meta file on
heap . At runtime, it processes that metadata to produce the right doc value
flavour, e.g dense vs sparse. This is a bit wasteful as we are holding more
data that it is required when we can process that metadata as soon as we read
it.
This commit proposes to process the metadata as soon as it is read in order
to keep just the necessary metadata required to build each doc values flavour.
In order to do that, it introduces DocValuesProducer for each doc value type.
Each producer contains the logic to parse the metadata and generate a factory
that holds just the necessary metadata for each doc value flavour.
This change should reduce the footprint for Lucene90DocValuesProducer and
IMHO it makes the code a bit easier to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
