Re: [PR] Move postings back to int[] to take advantage of having more lanes per vector. [lucene]

[via GitHub]

gsmiller commented on code in PR #13968:
URL: https://github.com/apache/lucene/pull/13968#discussion_r1824790729


##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/PostingDecodingUtil.java:
##########
@@ -55,4 +55,30 @@ public void splitLongs(
       c[cIndex + i] &= cMask;
     }
   }
+
+  /**
+   * Core methods for decoding blocks of docs / freqs / positions / offsets.
+   *
+   * <ul>
+   *   <li>Read {@code count} ints.
+   *   <li>For all {@code i} &gt;= 0 so that {@code bShift - i * dec} &gt; 0, 
apply shift {@code
+   *       bShift - i * dec} and store the result in {@code b} at offset 
{@code count * i}.
+   *   <li>Apply mask {@code cMask} and store the result in {@code c} starting 
at offset {@code
+   *       cIndex}.
+   * </ul>
+   */
+  public void splitInts(

Review Comment:
   Should we drop `#splitLongs`? (Also, should we add `@lucene.internal` to 
this class so we're free to drop public methods?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org