uschindler commented on code in PR #13578: URL: https://github.com/apache/lucene/pull/13578#discussion_r1680884653
########## lucene/test-framework/src/java/org/apache/lucene/tests/store/MockDirectoryWrapper.java: ########## @@ -814,6 +814,14 @@ public synchronized IndexInput openInput(String name, IOContext context) throws context = LuceneTestCase.newIOContext(randomState, context); final boolean confined = context == IOContext.READONCE; Review Comment: Ah nice. We have removed the IOContext in checksum IndexInput in main branch. 👍 I think the suggested change here is not needed. It's legacy code anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org