dweiss commented on PR #13456:
URL: https://github.com/apache/lucene/pull/13456#issuecomment-2151807298

   > I think that this is good. Would it run on all CI jobs, or you somehow 
opt-in?
   
   There is a filtering restriction - it'll run on PRs and pushes to these two 
branches and when the commit matches path specs. I think this restricts it 
reasonably well.
   ```
       branches:
         - 'main'
         - 'branch_9x'
       paths:
         - '.github/workflows/run-checks-gradle-upgrade.yml'
         - 'gradle/wrapper/**'
   ```
   
   > Running with RUNTIME_JAVA_HOME does have a slightly different code path in 
the gradle build files. Not sure if that could be easily covered.
   
   Yes, I think so. The run-nightly-smoketester.yml workflow uses this explicit 
variable to test against 22-ea.
   
   There are probably more tasks/ paths to cover. This is just a PoC and a 
start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to