slow-J opened a new pull request, #12876: URL: https://github.com/apache/lucene/pull/12876
When I was working on `CheckIndex` in PR: https://github.com/apache/lucene/pull/12797, Issue: https://github.com/apache/lucene/issues/11023, I came across some dead code that I wanted to clean up as a follow-up. List of changes: * Removed `testPostings` and `testTermVectors`, these methods with 2 params are never called in Lucene * Collections.sort -> List.sort, Collections.sort simply delegates to List.sort anyways * println(String.format) -> printf * Removal of some unused params in private methods * Adding more usage of existing `numDocs` variable Please let me know if any of these changes are not needed or are Lucene coding conventions and I will change them back. If approved in current form, `testPostings` and `testTermVectors` with 2 params will need to be `@Deprecated` in a 9.x version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
