jpountz commented on PR #12823: URL: https://github.com/apache/lucene/pull/12823#issuecomment-1818519650
I don't have a strong opinion on this change, but historically there's been push back on this kind of changes, because while they reduce the total number of lines, they also introduce one more abstraction so you need to check out two different things instead of one to understand what reading N-bits integers does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
