cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1358513093
##########
lucene/analysis/opennlp/src/test/org/apache/lucene/analysis/opennlp/TestOpenNLPChunkerFilterFactory.java:
##########
@@ -58,7 +58,7 @@ public class TestOpenNLPChunkerFilterFactory extends
BaseTokenStreamTestCase {
8, 15, 17, 21, 23, 29, 30, 39, 46, 48, 49, 51, 57, 58
};
private static final String[] SENTENCES_chunks = {
- "B-NP", "I-NP", "I-NP", "B-VP", "B-NP", "I-NP", "O", "B-NP", "I-NP",
"I-NP", "O", "B-NP",
+ "B-NP", "I-NP", "I-NP", "I-NP", "I-NP", "I-NP", "O", "B-NP", "I-NP",
"I-NP", "O", "B-NP",
Review Comment:
This change so far is naively what makes the tests pass ... however
```suggestion
"B-NP", "I-NP", "I-NP", "I-VP", "I-NP", "I-NP", "O", "B-NP", "I-NP",
"I-NP", "O", "B-NP",
```
i.e. `"I-VP"` for `"has"` would seem more correct, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
