dungba88 commented on issue #12543:
URL: https://github.com/apache/lucene/issues/12543#issuecomment-1761024337
Copied from the PR:
It seems Tantivy segregate the building and the traverse of FST as 2
different entity. The FST Builder will just write the FST to a DataOutput and
not allow it to be read directly. I was thinking of this too, as currently we
are mixing up the writing and reading:
- Load a previously saved FST from a DataInput. This is read-only and is
fine, and it's how Tantivy FST is created as well.
- Construct a FST on-the-fly and use it right away. This is both read &
write and it uses BytesStore.
I'm kind of favoring the way Tantivy is doing, it's cleaner and more "facade
pattern". Maybe we could create an experimental FST Builder, that only save the
FST into DataOutput?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
