vsop-479 commented on PR #12528: URL: https://github.com/apache/lucene/pull/12528#issuecomment-1757016549
@iverase Here is a performance data of geo cases. There are some slowdown due to the extra check. query | metric | baseline | candidate | Diff -- | -- | -- | -- | -- poly-10-geo3d | BEST M hits/sec | 68.13 | 67.99 | -0.2% --| BEST QPS | 43.07 | 42.99 | -0.1% box-geo3d | BEST M hits/sec | 73.63 | 72.86 | -0.1% --| BEST QPS | 74.92 | 74.14 | -0.1% I want to add a enhanced IntersectVisitor type or add a flag to IntersectVisitor, for queries which have already implemented visitWithSortedDim. And leave queries which haven't or couldn't implement visitWithSortedDim, use the original visit method to avoid the unnecessary checks. Does it make sense to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
