gsmiller commented on PR #12310: URL: https://github.com/apache/lucene/pull/12310#issuecomment-1556069606
@mikemccand the `build` method you reference above in `DaciukMihovAutomatonBuilder` build an automaton with code points as transition labels, but I think we need a "compiled" binary automaton for this visitor? We can have `CompiledAutomaton` do this conversion, but it's pretty wasteful to build one way then convert it when we could build directly to binary? I opened a separate PR that can do a direct binary build over in #12320. I might be completely overlooking a simpler way to do this with code we already have though, so I'm happy to close that PR out in favor of a simpler approach if one exists. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
