shubhamvishu opened a new pull request, #12183: URL: https://github.com/apache/lucene/pull/12183
### Description This change tries to make some queries with heavy rewrites make use of concurrency using the api added in #11840. In #12160 it turns out have good gains in KnnVectorQuery. This is initial rough implementation to get some early thoughts/feedback on or ideas on if this could be useful and worth pursuing for some other queries as well which are doing some heavy lifting in rewrite. This change initially tries to achieve some benefit of concurrency for `FieldExistsQuery` , `BlendedTermQuery` and `CompletionQuery`.There are also others also I could find which are not covered in this but maybe could benefit with concurrency. Queries changed to have || rewrite in this PR: 1. FieldExistsQuery 2. BlendedTermQuery 3. CompletionQuery Some possible candidate(s) with non-trivial rewrites ? - CommonTermsQuery - SpanNearQuery - SpanOrQuery - CoveringQuery - DisjunctionMaxQuery Benchmarks : yet to be run PS : As some query rewrites calls rewrites on the child/sub queries. Can we achieve this in those queries as well? So I tried to make `DisjunctionMaxQuery#rewrite` concurrent but that seems to get stuck on my machine when running `TestDisjunctionMaxQuery` unit test. Maybe thats too much parallelism as the test is randomly generating a very large disjunctive query and making that rewrite concurrent is not correct or helpful ? <!-- If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide. https://github.com/apache/lucene/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
