mikemccand commented on PR #11796: URL: https://github.com/apache/lucene/pull/11796#issuecomment-1285872091
This looks great to me! I love all the engagement (83+ comments!) and how it iterated to such a simple solution. I left a small comment for a follow-on issue ... and it looks like `CHANGES.txt` is conflicting again @mdmarshmallow maybe open another follow-on issue in `luceneutil` to add this to nightly benchmarks? It'd be great to see impact on WAF over time of interesting index-time changes... I'll push this in a few days if nobody objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org