magibney commented on pull request #380: URL: https://github.com/apache/lucene/pull/380#issuecomment-1006945362
That definitely makes sense. Despite all my caution, my own inclination honestly is essentially to "just do it". For all the reasons you've identified and as we've discussed further, this _really_ seems like the right thing to do, and the odds of users having: 1. written extensions to call this method, and 2. already upgraded to 9.0 and washed their hands of the upgrade ... yeah, the odds seem pretty low of this being a practical problem. @alessandrobenedetti what do you think? Any further sense of who takes a special interest in this part of the code, and/or might be more keyed into the ways in which the community may have extended this (or not)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
