spyk commented on pull request #380: URL: https://github.com/apache/lucene/pull/380#issuecomment-1006905936
Thank you @magibney for sharing your thoughts and also for taking the cautious approach! I think your concerns make sense, to be honest I had not thought of the public API change (had that particular class as a helper class in my mind). But, I don't have the complete picture either, since I'm coming mostly from a Solr-based usage perspective. I do think, however, that we should communicate at some point at least the drawbacks / dangers of using the particular implementation, as it can severely impact performance in unexpected ways. Not sure what would be the best way to do that though. eg. deprecate the API, or add an explicit warning on the documentation? Looking forward to other suggestions from other committers, and once more, thank you for all the help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
