dweiss commented on a change in pull request #556:
URL: https://github.com/apache/lucene/pull/556#discussion_r772625522
##########
File path:
lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestModularLayer.java
##########
@@ -292,4 +293,17 @@ public void testAllOpenPackagesInSync() throws IOException
{
.collect(Collectors.toCollection(TreeSet::new));
}
}
+
Review comment:
I think this should go into modular tests for lucene.core(.test) instead
of the distribution tests - there it makes more sense and you don't have to
load the module dynamically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
