uschindler commented on a change in pull request #556:
URL: https://github.com/apache/lucene/pull/556#discussion_r772603688
##########
File path: lucene/core/src/test/org/apache/lucene/store/TestMultiMMap.java
##########
@@ -36,7 +36,7 @@ protected Directory getDirectory(Path path, int maxChunkSize)
throws IOException
@Override
public void setUp() throws Exception {
super.setUp();
- assumeTrue(MMapDirectory.UNMAP_NOT_SUPPORTED_REASON,
MMapDirectory.UNMAP_SUPPORTED);
+ assertTrue(MMapDirectory.UNMAP_NOT_SUPPORTED_REASON,
MMapDirectory.UNMAP_SUPPORTED);
Review comment:
possibly this check should be class-level, because method-level makes it
fail hundreds of times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
