[ https://issues.apache.org/jira/browse/LUCENE-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand resolved LUCENE-10114. ----------------------------------- Resolution: Fixed > Remove unused byte order mark in Lucene90PostingsWriter > ------------------------------------------------------- > > Key: LUCENE-10114 > URL: https://issues.apache.org/jira/browse/LUCENE-10114 > Project: Lucene - Core > Issue Type: Task > Components: core/codecs, core/index > Affects Versions: 9.0 > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Priority: Major > Fix For: 9.0 > > Time Spent: 20m > Remaining Estimate: 0h > > While reviewing the byte order in lucene index, I found the following code in > {{Lucene90PostingsWriter}}: > {code:java} > ByteOrder byteOrder = ByteOrder.nativeOrder(); > if (byteOrder == ByteOrder.BIG_ENDIAN) { > docOut.writeByte((byte) 'B'); > } else if (byteOrder == ByteOrder.LITTLE_ENDIAN) { > docOut.writeByte((byte) 'L'); > } else { > throw new Error(); > } > {code} > Actually this byte is consumed nowhere, as the file is only used via seeking > and the offsets are just 1 larger. We should remove this code. > Why was this added? -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org