zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-969846412
> Hi @jpountz @jimczi, when I was doing some more deep dive to see how this PR can be improved further, I noticed a difference of field-weight parameter passed to create`MultiNormsLeafSimScorer` in `CombinedFieldQuery`: > > `CombinedFieldQuery#scorer`: > > https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L420-L421 > > `CombinedFieldQuery#explain`: > > https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L387-L389 > > For the `CombinedFieldQuery#scorer` one, `fields` may contain duplicated fields: > > https://github.com/apache/lucene/blob/3b914a4d73eea8923f823cbdb869de39213411dd/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java#L404-L414 > > , whereas `fieldAndWeights.values()` should not contain duplicated fields. > > I feel `CombinedFieldQuery#scorer` should be updated to use `fieldAndWeights.values()` as well? What do you think? For now I have created a spin-off issue https://issues.apache.org/jira/browse/LUCENE-10236 and a separate PR https://github.com/apache/lucene/pull/444 for this. Please let me know if they look good to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
