sejal-pawar commented on a change in pull request #159:
URL: https://github.com/apache/lucene/pull/159#discussion_r641856799
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##########
@@ -335,10 +342,22 @@ protected boolean scoreSubDocsAtOnce() {
/** Hits. */
public final TopDocs hits;
+ /** Collector to compute Facets */
+ FacetsCollector drillDowns;
+
+ /** drill-down dimensions */
+ Map<String, Integer> drillDownDims;
Review comment:
Oh okay, understood. In that case why not keep `DrillSidewaysResult`
consistent with the signature of `buildFacetResult` and have `FacetsCollector
drillDowns, FacetsCollector[] drillSideways`, String[] drillSidewaysDims`
exposed as is instead of `Map<String, FacetsCollector>`? Or alternatively is it
possible to consider revising signature of `buildFacetResult`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
