[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353119#comment-17353119 ]
Jim Ferenczi commented on LUCENE-9204: -------------------------------------- The rewriting of disjunctions that contains duplicate is simple to explain and to reason about. It is slower indeed but there's nothing else to compare with since it's the key for correctness. Taking aside the difference between spans and intervals, I think this example demonstrates how we can approach this kind of issue. We have a complex semantic based on minimum intervals that comes with limitations. We can try to break these limitations but most of the time that will change another layer that expects correctness So in this case, we apply a simple transformation that doesn't require to change the semantic. I don't think we can/should allow for leniency here, it is correct or it's not. We can evaluate the cost to keep correctness in some situations but I don't think there's any trade-offs to find. If it's not correct, it's a bug, not a feature ;). > Move span queries to the queries module > --------------------------------------- > > Key: LUCENE-9204 > URL: https://issues.apache.org/jira/browse/LUCENE-9204 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Major > Fix For: main (9.0) > > Time Spent: 1h > Remaining Estimate: 0h > > We have a slightly odd situation currently, with two parallel query > structures for building complex positional queries: the long-standing span > queries, in core; and interval queries, in the queries module. Given that > interval queries solve at least some of the problems we've had with Spans, I > think we should be pushing users more towards these implementations. It's > counter-intuitive to do that when Spans are in core though. I've opened this > issue to discuss moving the spans package as a whole to the queries module. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org