glawson0 opened a new pull request #157: URL: https://github.com/apache/lucene/pull/157
<!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene: * https://issues.apache.org/jira/projects/LUCENE You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description There are various situations were the flatten graph filter may throw an exception or drop tokens due to mishandling of holes in the analysis graph. The primary causes were 1) Output nodes that were hole destinations and valid sources 2) Freeing nodes before they had been fully resolved 3) Putting edges at incorrect output nodes after a hole # Solution 1)Iterate through all output.InputNodes since dest gaps can exist 2)Freebefore the minimum input node not the first input node(which is usually, but not always, the minimum) 3)Recovery nodes that have end offset less than their preceeding node gaplessly follow their preceeding node 4)Ensure nodes positionInc >1 are arriving at the end of the graph. # Tests same tests as https://github.com/apache/lucene/pull/146 plus tests for shingled tokens and gaps at the start of a token graph. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
