gautamworah96 opened a new pull request #62:
URL: https://github.com/apache/lucene/pull/62
Changes:
1. Update getOrdinal(String, String[]) call to getOrdinal(String,
String...)
2. Update getValue(int) API to be protected
<!--
_(If you are a project committer then you may remove some/all of the
following template.)_
Before creating a pull request, please file an issue in the ASF Jira system
for Lucene:
* https://issues.apache.org/jira/projects/LUCENE
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
LUCENE must be fully capitalized. A short description helps people scanning
pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly
updated with code review comments and commits. -->
# Description
I was using the public int getOrdinal(String dim, String[] path) API for a
single path String and found myself creating an array with a single element. We
can start using variable length args for this method.
I also propose this change:
I wanted to know the specific count of an ordinal using using the getValue
API from IntTaxonomyFacets but the method is private. It would be good if we
could change it to protected so that users can know the value of an ordinal
without looking up the FacetLabel and then checking its value.
# Solution
Changed the function definition and access modifier.
Checked that no other method used the `String[]` parameter. Also checked
that other methods that deal with `ordinals` and `values` in
`IntTaxonomyFacets` are also `protected`
# Tests
Already existing tests cover these methods.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code
conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Lucene maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
