ctargett commented on a change in pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870#discussion_r504903798
##########
File path: solr/solr-ref-guide/src/metrics-reporting.adoc
##########
@@ -534,15 +534,34 @@ These metrics are available only on a per-core basis.
Metrics can be aggregated
These metrics are collected in respective registries for each core (e.g.,
`solr.core.collection1....`), under the `INDEX` category.
-Basic metrics are always collected - collection of additional metrics can be
turned on using boolean parameters in the `/config/indexConfig/metrics` section
of `solrconfig.xml`:
+Metrics collection is controlled by boolean parameters in the
`/config/indexConfig/metrics` section of `solrconfig.xml`:
+
Review comment:
I was a little confused by the fully qualified XML path here, we don't
do that in other places in the docs so it jumped out at me. If we think maybe
we should do that more often, this would be fine and I can make an issue to
update other places in the Guide to someday be consistent but otherwise I only
wonder if it would be jarring for others also (I might be alone in my
impression).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
