PuneethBikkumanla opened a new pull request #1858: URL: https://github.com/apache/lucene-solr/pull/1858
# Description Hey everyone! This is my first PR. In this PR, I am addressing the concern of the original ticket that the equals method is asymmetrically comparing two objects. I currently changed some of the files requested in the ticket but will go ahead and change the rest once I know I'm on the right path. Also, am currently figuring out how/where to add documentation changes to the Ref Guide regarding this PR. # Solution Instead of using `instanceOf` I used `getClass` in the `equals` method as described in the original Jira ticket # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. Currently I have not added any tests to verify this change as the existing tests that I found for these classes do not make it easy to test this. I just wanted to open up a PR to check whether I'm on the right track and for some help on figuring out where/how I could test these changes. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
