markharwood edited a comment on pull request #1708: URL: https://github.com/apache/lucene-solr/pull/1708#issuecomment-668124174
>I wonder if the parsing should be more strict and only matches if there is a separator or ends after the i ? You're right that this means a breaking change. I just tested range queries ie `num:[1 TO 5]i` and that tolerates no whitespace between the closing `]` and a search for the letter `i` so it's currently legal syntax (although weird and probably rare). I hadn't considered adding a flag for 8.x. If we do I'd prefer to see it support the new behaviour by default - the rationale being that it is better to give an escape hatch to the few admins concerned about BWC for an edge case than continue the legacy of silent failures for potentially many regex searchers assuming `/Foo/i` was supported syntax. >I wonder if the parsing should be more strict Yep - end-of-string or space would be required after the end of the regex. Maybe brackets too for Boolean logic? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
