mbwaheed opened a new pull request #1430: SOLR-13101: SHARED replica's distributed indexing URL: https://github.com/apache/lucene-solr/pull/1430 The basic purpose of this change was to refactor most of the SHARED replica logic out of DistributedZkUpdateProcessor. Along with that refactoring I came across couple of functional issues in the logic that have been fixed too. Functional fixes: -If a replica looses its leadership in the middle of indexing batch, it should still push its changes to the shared store. -SHARED replica does not need to process soft commits and does not need to broadcast hard commits to all the shards of a collection. -Previously we would pull from the shared store even when the doc being added/deleted is not meant for the current core/shard. -Previously DistributedZkUpdateProcessor#processDelete was running its pull logic even before the request had been setup (DistributedZkUpdateProcessor#setupRequest). -DistributedZkUpdateProcessorTest have been deleted in favor of new SharedStoreDistributedIndexingTest and SharedCoreIndexingBatchProcessorTest. Refactoring: -Most of DistributedZkUpdateProcessor's SHARED replica logic is moved into a new SharedCoreIndexingBatchProcessor. The purpose of this class is to pull from the shared store at the start of an indexing batch (if the core is stale) and push to the shared store at the end of a successfully committed indexing batch. -CoreUpdateTracker has been deleted and its only persistShardIndexToSharedStore method has been renamed to pushCoreToSharedStore and moved to CorePusher. -BlobStoreUtilsTest#syncLocalCoreWithSharedStore is renamed to pullCoreFromSharedStore and moved into a new CorePuller class and the tests to CorePullerTests. -I did rename phrase "blob store" to "shared store" at some places in the changed classes. But it was not meant to be an exhaustive attempt.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
