[
https://issues.apache.org/jira/browse/LUCENE-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053432#comment-17053432
]
ASF subversion and git services commented on LUCENE-9257:
---------------------------------------------------------
Commit e7a61eadf6d2f3c722c791e7470a79b2e919cdeb in lucene-solr's branch
refs/heads/branch_8x from Bruno Roustant
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e7a61ea ]
LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode, Reader attributes
and openedFromWriter.
> FSTLoadMode should not be BlockTree specific as it is used more generally in
> index package
> ------------------------------------------------------------------------------------------
>
> Key: LUCENE-9257
> URL: https://issues.apache.org/jira/browse/LUCENE-9257
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Bruno Roustant
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> FSTLoadMode and its associate attribute key (static String) are currently
> defined in BlockTreeTermsReader, but they are actually used outside of
> BlockTree in the general "index" package.
> CheckIndex and ReadersAndUpdates are using these enum and attribute key to
> drive the FST load mode through the SegmentReader which is not specific to a
> postings format. They have an unnecessary dependency to BlockTreeTermsReader.
> We could move FSTLoadMode out of BlockTreeTermsReader, to make it a public
> enum of the "index" package. That way CheckIndex and ReadersAndUpdates do not
> import anymore BlockTreeTermsReader.
> This would also allow other postings formats to use the same enum (e.g.
> LUCENE-9254)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
