[ https://issues.apache.org/jira/browse/LUCENE-9142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031889#comment-17031889 ]
ASF subversion and git services commented on LUCENE-9142: --------------------------------------------------------- Commit abd282d258d23d19b7f7c1e96332a19fa7b7b827 in lucene-solr's branch refs/heads/master from Mike [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=abd282d ] LUCENE-9142 Refactor IntSet operations for determinize (#1184) * LUCENE-9142 Refactor SortedIntSet for equality Split SortedIntSet into a class heirarchy to make comparisons to FrozenIntSet more meaningful. Use Arrays.equals for more efficient comparison. Add tests for IntSet to verify correctness. > Add documentation to Operations.determinize, SortedIntSet, and FrozenSet > ------------------------------------------------------------------------ > > Key: LUCENE-9142 > URL: https://issues.apache.org/jira/browse/LUCENE-9142 > Project: Lucene - Core > Issue Type: Bug > Components: core/search > Reporter: Mike Drob > Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > Was tracing through the fuzzy query code, and IntelliJ helpfully pointed out > that we have mismatched types when trying to reuse states, and so we may be > creating more states than we need to. > Relevant snippets: > {code:title=Operations.java} > Map<SortedIntSet.FrozenIntSet,Integer> newstate = new HashMap<>(); > final SortedIntSet statesSet = new SortedIntSet(5); > Integer q = newstate.get(statesSet); > {code} > {{q}} is always going to be null in this path because there are no > SortedIntSet keys in the map. > There are also very little javadoc on SortedIntSet, so I'm having trouble > following the precise relationship between all the pieces here. > cc: [~mikemccand] [~romseygeek] - I would appreciate any pointers if you have > them -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org