[
https://issues.apache.org/jira/browse/SOLR-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018027#comment-17018027
]
ASF subversion and git services commented on SOLR-14184:
--------------------------------------------------------
Commit 5f2d7c4855987670489d68884c787e4cfb377fa9 in lucene-solr's branch
refs/heads/gradle-master from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5f2d7c4 ]
SOLR-14184: Internal 'test' variable DirectUpdateHandler2.commitOnClose has
been removed and replaced with TestInjection.skipIndexWriterCommitOnClose
> replace DirectUpdateHandler2.commitOnClose with (negated)
> TestInjection.skipIndexWriterCommitOnClose
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-14184
> URL: https://issues.apache.org/jira/browse/SOLR-14184
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: master (9.0), 8.5
>
> Attachments: SOLR-14184.patch, SOLR-14184.patch
>
>
> {code:java}
> public static volatile boolean commitOnClose = true; // TODO: make this a
> real config option or move it to TestInjection
> {code}
> Lots of tests muck with this (to simulate unclean shutdown and force tlog
> replay on restart) but there's no garuntee that it is reset properly.
> It should be replaced by logic in {{TestInjection}} that is correctly cleaned
> up by {{TestInjection.reset()}}
> ----
> It's been replaced with the (negated) option
> {{TestInjection.skipIndexWriterCommitOnClose}} which is automatically reset
> to it's default value of {{false}} by {{TestInjection.reset()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
