[ 
https://issues.apache.org/jira/browse/SOLR-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009836#comment-17009836
 ] 

David Smiley commented on SOLR-14174:
-------------------------------------

Fix is trivial.
Inner class "Iter extends SortedDocValues" should have a cost of 
{{docToTermOrd.size();}}
Inner class BinaryDocValuesImpl's Iterator cost should be 
{{docToOffset.size();}}

[~gerlowskija] FYI discovered this while debugging your PR on SOLR-13890

> FieldCache DV DocIdSetIterator cost methods are sometimes bad
> -------------------------------------------------------------
>
>                 Key: SOLR-14174
>                 URL: https://issues.apache.org/jira/browse/SOLR-14174
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Major
>
> The implementation of DocIdSetIterator.cost() in FieldCacheImpl (i.e. 
> uninverted DVs) is sometimes a constant 0, thus suggesting ultra-cheap 
> iteration.  This is for BinaryDocValues, and SortedDocValues.  Fortunately, 
> NumericDocValues is fine.  A correct implementation should return the number 
> of documents containing a value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to