[ 
https://issues.apache.org/jira/browse/SOLR-13904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991677#comment-16991677
 ] 

Houston Putman edited comment on SOLR-13904 at 12/9/19 3:04 PM:
----------------------------------------------------------------

This looks good to me. What was the change that caused it to be 100% 
reproducible?

The only change I would suggest is to do the testing AssertTrue directly after 
making the call with timeAllowed, instead of setting a flag that you check in a 
method after the test.


was (Author: houston):
This looks good to me. What was the change that caused it to be 100% 
reproducible?

> Make Analytics component aware of timeAllowed
> ---------------------------------------------
>
>                 Key: SOLR-13904
>                 URL: https://issues.apache.org/jira/browse/SOLR-13904
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mikhail Khludnev
>            Assignee: Houston Putman
>            Priority: Major
>         Attachments: SOLR-13904.patch, SOLR-13904.patch, SOLR-13904.patch, 
> SOLR-13904.patch, SOLR-13904.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to