[
https://issues.apache.org/jira/browse/LUCENE-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988431#comment-16988431
]
Erick Erickson commented on LUCENE-9080:
----------------------------------------
OK, I'm a little lost here. [~uschindler][~rmuir][~jpountz] any clues? What I'm
really wondering is if it's common practice to run the regenerate task, then
fix up the problems then check stuff in.
For instance there are three separate CharStream.java files that are generated
with deprecated methods in them. I tried removing all references to those
methods before running the regenerate task and they _still_ came back, from
where?
Several files have a large number of unused imports and precommit fails.
QueryParser.java winds up with this line:
{code}
private java.util.List jj_expentries = new java.util.ArrayList();
{code}
which is changed to
{code}
private java.util.List<int[]> jj_expentries = new java.util.ArrayList<int[]>();
{code}
And so on. Is it just the case that all this kind of thing needs to be fixed by
hand after the regenerate task is run? Or is the regenerate task something that
should only be run by experts and I should give up ;)?
> "ant regenerate" fails on master
> --------------------------------
>
> Key: LUCENE-9080
> URL: https://issues.apache.org/jira/browse/LUCENE-9080
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: after_regen.patch, before_regen.patch, status.res
>
>
> The root cause is that RamUsageEstimator.NUM_BYTES_INT has been removed and
> the python scripts still reference it in the generated scripts. That part's
> easy to fix.
> Last time I looked, though, the regenerate produces some differences in the
> generated files that should be looked at to insure they're benign.
> Not really sure whether this should be a Lucene or Solr JIRA. Putting it in
> Lucene since one of the failed files is:
> lucene/core/src/java/org/apache/lucene/util/packed/Packed8ThreeBlocks.java
> I do know that one of the Solr jflex-produced file has an unexplained
> difference so it may bleed over.
> "ant regenerate" needs about 24G on my machine FWIW.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
