[
https://issues.apache.org/jira/browse/KYLIN-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071506#comment-18071506
] ASF GitHub Bot commented on KYLIN-4972: --------------------------------------- codecov-commenter commented on PR #1634: URL: https://github.com/apache/kylin/pull/1634#issuecomment-4194236714 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1634?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 25.32%. Comparing base ([`0250081`](https://app.codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6e5552`](https://app.codecov.io/gh/apache/kylin/commit/b6e555203ae6dc297c4a7e7374fb7c340e5b2420?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1634?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ava/org/apache/kylin/rest/service/CubeService.java](https://app.codecov.io/gh/apache/kylin/pull/1634?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://app.codecov.io/gh/apache/kylin/pull/1634?src=pr&el=tree&filepath=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #1634 +/- ## ============================================ - Coverage 25.42% 25.32% -0.10% + Complexity 6765 6760 -5 ============================================ Files 1508 1509 +1 Lines 93918 94237 +319 Branches 13158 13211 +53 ============================================ - Hits 23877 23869 -8 - Misses 67662 67984 +322 - Partials 2379 2384 +5 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1634?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Don't allow segment merge when use dict.global.SegmentAppendTrieDictBuilder > to build bitmap measure > --------------------------------------------------------------------------------------------------- > > Key: KYLIN-4972 > URL: https://issues.apache.org/jira/browse/KYLIN-4972 > Project: Kylin > Issue Type: Improvement > Reporter: JiangYang > Assignee: JiangYang > Priority: Minor > Fix For: v3.1.3 > > > When *org.apache.kylin.dict.global.SegmentAppendTrieDictBuilder* is used for > bitmap count distinct measure, cube segment merge will lead to incorrect > bitmap merge. Therefore, we should forbid segment merge in this case. -- This message was sent by Atlassian Jira (v8.20.10#820010)
