[
https://issues.apache.org/jira/browse/KYLIN-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071305#comment-18071305
]
ASF GitHub Bot commented on KYLIN-4063:
---------------------------------------
codecov-commenter commented on PR #733:
URL: https://github.com/apache/kylin/pull/733#issuecomment-4189558413
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/733?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 25.70%. Comparing base
([`96ba0c6`](https://app.codecov.io/gh/apache/kylin/commit/96ba0c66889e0caa29f52c3d740536ef81d8dc5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`a277c29`](https://app.codecov.io/gh/apache/kylin/commit/a277c29b7b0f7e274e86a3fa2d0a39371bfde0a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #733 +/- ##
============================================
- Coverage 25.72% 25.70% -0.03%
+ Complexity 6019 6016 -3
============================================
Files 1386 1386
Lines 82708 82712 +4
Branches 11599 11600 +1
============================================
- Hits 21280 21264 -16
- Misses 59379 59393 +14
- Partials 2049 2055 +6
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/733?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Avoid repeatedly calling "string.toLowerCase" in TimedJsonStreamParser#parse
> ----------------------------------------------------------------------------
>
> Key: KYLIN-4063
> URL: https://issues.apache.org/jira/browse/KYLIN-4063
> Project: Kylin
> Issue Type: Improvement
> Components: NRT Streaming
> Reporter: Shao Feng Shi
> Assignee: Yaqian Zhang
> Priority: Major
>
> In TimedJsonStreamParser#parse, it has this:
>
> {code:java}
> for (TblColRef column : allColumns) {
> final String columnName = column.getName().toLowerCase(Locale.ROOT);
> if (populateDerivedTimeColumns(columnName, result, t) == false) {
> result.add(getValueByKey(column, root));
> }
> }
> {code}
>
> As this method will be invoked for each message, and then for each column it
> will have a "toLowerCase(Locale.ROOT)", which is unnecessary, because the
> "allColumns" won't change.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
