[
https://issues.apache.org/jira/browse/KYLIN-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071220#comment-18071220
] ASF GitHub Bot commented on KYLIN-4877: --------------------------------------- codecov-commenter commented on PR #1547: URL: https://github.com/apache/kylin/pull/1547#issuecomment-4188864874 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1547?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `50.00000%` with `3 lines` in your changes missing coverage. Please review. :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`kylin-on-parquet-v2@e719f7b`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1547?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/kylin/engine/spark/job/CubeBuildJob.java](https://app.codecov.io/gh/apache/kylin/pull/1547?src=pr&el=tree&filepath=kylin-spark-project%2Fkylin-spark-engine%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2Fjob%2FCubeBuildJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3lsaW4tc3BhcmstcHJvamVjdC9reWxpbi1zcGFyay1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3Bhcmsvam9iL0N1YmVCdWlsZEpvYi5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/kylin/engine/spark/job/CubeMergeJob.java](https://app.codecov.io/gh/apache/kylin/pull/1547?src=pr&el=tree&filepath=kylin-spark-project%2Fkylin-spark-engine%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2Fjob%2FCubeMergeJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3lsaW4tc3BhcmstcHJvamVjdC9reWxpbi1zcGFyay1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3Bhcmsvam9iL0N1YmVNZXJnZUpvYi5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/kylin/engine/spark/utils/Repartitioner.java](https://app.codecov.io/gh/apache/kylin/pull/1547?src=pr&el=tree&filepath=kylin-spark-project%2Fkylin-spark-engine%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2Futils%2FRepartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3lsaW4tc3BhcmstcHJvamVjdC9reWxpbi1zcGFyay1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvdXRpbHMvUmVwYXJ0aXRpb25lci5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## kylin-on-parquet-v2 #1547 +/- ## ====================================================== Coverage ? 24.27% Complexity ? 4623 ====================================================== Files ? 1144 Lines ? 65277 Branches ? 9584 ====================================================== Hits ? 15845 Misses ? 47784 Partials ? 1648 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1547?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Use all dimension columns as sort columns when saving cuboid data > ----------------------------------------------------------------- > > Key: KYLIN-4877 > URL: https://issues.apache.org/jira/browse/KYLIN-4877 > Project: Kylin > Issue Type: Improvement > Components: Spark Engine > Affects Versions: v4.0.0-alpha > Reporter: Zhichao Zhang > Assignee: Zhichao Zhang > Priority: Minor > Fix For: v4.0.0-beta > > > Use all dimension columns as sort columns when saving cuboid data. > This change will reduce the size of cuboid data (about the RLE encoding of > parquet). -- This message was sent by Atlassian Jira (v8.20.10#820010)
