[
https://issues.apache.org/jira/browse/KYLIN-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071152#comment-18071152
]
ASF GitHub Bot commented on KYLIN-4027:
---------------------------------------
codecov-commenter commented on PR #702:
URL: https://github.com/apache/kylin/pull/702#issuecomment-4188427891
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 25.72%. Comparing base
([`9708990`](https://app.codecov.io/gh/apache/kylin/commit/970899011211b285b78cfc3a63ac5025436ddb59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`67b4106`](https://app.codecov.io/gh/apache/kylin/commit/67b4106a5a94029fd074edce00e5561e4eee86a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #702 +/- ##
============================================
- Coverage 25.74% 25.72% -0.02%
+ Complexity 6014 6012 -2
============================================
Files 1385 1385
Lines 82424 82424
Branches 11557 11557
============================================
- Hits 21216 21204 -12
- Misses 59167 59175 +8
- Partials 2041 2045 +4
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/702?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Kylin-jdbc module has tcp resource leak
> ---------------------------------------
>
> Key: KYLIN-4027
> URL: https://issues.apache.org/jira/browse/KYLIN-4027
> Project: Kylin
> Issue Type: Bug
> Components: Driver - JDBC
> Affects Versions: all
> Reporter: Hongsen Liu
> Priority: Major
> Labels: easyfix
> Fix For: v3.0.0-alpha2
>
>
> In Kylin-jdbc module, the class KylinClient has TCP resource leak when it
> sends http request. For example, like the following code snipper
>
> {quote}HttpResponse response = httpClient.execute(post);
> try {
> if (response.getStatusLine().getStatusCode() != 200 &&
> response.getStatusLine().getStatusCode() != 201) {
> throw asIOException(post, response);
> }
> SQLResponseStub stub = jsonMapper.readValue(
> response.getEntity().getContent(), SQLResponseStub.class);
> return stub;
> } finally {
> post.releaseConnection();
> }
> {quote}
> The code HttpClient.execute(post) is not in try segment, if it throws
> exception internally ,
> the finally segment won't run.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
