[
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071110#comment-18071110
] ASF GitHub Bot commented on KYLIN-4554: --------------------------------------- codecov-commenter commented on PR #1628: URL: https://github.com/apache/kylin/pull/1628#issuecomment-4187747541 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1628?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `60 lines` in your changes missing coverage. Please review. :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`kylin-on-parquet-v2@6153889`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1628?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/kylin/metadata/util/ModelUtil.java](https://app.codecov.io/gh/apache/kylin/pull/1628?src=pr&el=tree&filepath=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Futil%2FModelUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvdXRpbC9Nb2RlbFV0aWwuamF2YQ==) | 0.00% | [47 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/kylin/rest/service/ModelService.java](https://app.codecov.io/gh/apache/kylin/pull/1628?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FModelService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Nb2RlbFNlcnZpY2UuamF2YQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ain/java/org/apache/kylin/job/JoinedFormatter.java](https://app.codecov.io/gh/apache/kylin/pull/1628?src=pr&el=tree&filepath=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FJoinedFormatter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGb3JtYXR0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## kylin-on-parquet-v2 #1628 +/- ## ====================================================== Coverage ? 24.25% Complexity ? 4648 ====================================================== Files ? 1147 Lines ? 65651 Branches ? 9666 ====================================================== Hits ? 15926 Misses ? 48047 Partials ? 1678 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1628?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Validate "filter condition" on model saving > ------------------------------------------- > > Key: KYLIN-4554 > URL: https://issues.apache.org/jira/browse/KYLIN-4554 > Project: Kylin > Issue Type: Improvement > Components: Metadata > Reporter: Shao Feng Shi > Assignee: Sun BiaoBiao > Priority: Major > Fix For: v4.0.0, v3.1.3 > > Attachments: WechatIMG397.png > > > When define a model, user can enter a filter condition (using to do data > filtering on loading). While the system doesn't validate the filtering > condition's syntax; Later when build the cube, the condition will be send to > Hive, Hive may report an error on the syntax, but at that time, it is > difficult to modify it. > > !WechatIMG397.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
