[
https://issues.apache.org/jira/browse/KYLIN-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070594#comment-18070594
] ASF GitHub Bot commented on KYLIN-4927: --------------------------------------- codecov-commenter commented on PR #1609: URL: https://github.com/apache/kylin/pull/1609#issuecomment-4177816928 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1609?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `13.33333%` with `26 lines` in your changes missing coverage. Please review. :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`kylin-on-parquet-v2@a8cecf3`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1609?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...g/apache/spark/dict/NGlobalDictBuilderAssist.scala](https://app.codecov.io/gh/apache/kylin/pull/1609?src=pr&el=tree&filepath=kylin-spark-project%2Fkylin-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fdict%2FNGlobalDictBuilderAssist.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3lsaW4tc3BhcmstcHJvamVjdC9reWxpbi1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9kaWN0L05HbG9iYWxEaWN0QnVpbGRlckFzc2lzdC5zY2FsYQ==) | 0.00% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...n/engine/spark/builder/CubeDictionaryBuilder.scala](https://app.codecov.io/gh/apache/kylin/pull/1609?src=pr&el=tree&filepath=kylin-spark-project%2Fkylin-spark-engine%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2Fbuilder%2FCubeDictionaryBuilder.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3lsaW4tc3BhcmstcHJvamVjdC9reWxpbi1zcGFyay1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvYnVpbGRlci9DdWJlRGljdGlvbmFyeUJ1aWxkZXIuc2NhbGE=) | 40.00% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://app.codecov.io/gh/apache/kylin/pull/1609?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## kylin-on-parquet-v2 #1609 +/- ## ====================================================== Coverage ? 24.33% Complexity ? 4648 ====================================================== Files ? 1145 Lines ? 65399 Branches ? 9605 ====================================================== Hits ? 15917 Misses ? 47813 Partials ? 1669 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1609?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Forbid to use AE when building Global Dict > ------------------------------------------ > > Key: KYLIN-4927 > URL: https://issues.apache.org/jira/browse/KYLIN-4927 > Project: Kylin > Issue Type: Improvement > Components: Spark Engine > Affects Versions: v4.0.0-beta > Reporter: Zhichao Zhang > Assignee: Zhichao Zhang > Priority: Minor > Fix For: v4.0.0 > > > When building Global Dict, it's forbidden to use AE, which will change the > partition num dynamically and lead to wrong Global Dict result. -- This message was sent by Atlassian Jira (v8.20.10#820010)
