[
https://issues.apache.org/jira/browse/KYLIN-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070515#comment-18070515
] ASF GitHub Bot commented on KYLIN-4340: --------------------------------------- codecov-commenter commented on PR #1074: URL: https://github.com/apache/kylin/pull/1074#issuecomment-4175307131 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1074?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 25.06%. Comparing base ([`2a9aa87`](https://app.codecov.io/gh/apache/kylin/commit/2a9aa87bb3833f80c29d462e5a1cd8c7a238b21e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`84949de`](https://app.codecov.io/gh/apache/kylin/commit/84949de6e0a47f68ea1293afa54eabb97f5b9990?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1074?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ylin/engine/spark/SparkBatchCubingJobBuilder2.java](https://app.codecov.io/gh/apache/kylin/pull/1074?src=pr&el=tree&filepath=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkBatchCubingJobBuilder2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtCYXRjaEN1YmluZ0pvYkJ1aWxkZXIyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #1074 +/- ## ============================================ - Coverage 25.07% 25.06% -0.01% - Complexity 6220 6224 +4 ============================================ Files 1438 1440 +2 Lines 87673 87882 +209 Branches 12256 12291 +35 ============================================ + Hits 21983 22029 +46 - Misses 63542 63694 +152 - Partials 2148 2159 +11 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1074?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Fix bug of get value of isSparkFactDistinctEnable for cube not correct > ---------------------------------------------------------------------- > > Key: KYLIN-4340 > URL: https://issues.apache.org/jira/browse/KYLIN-4340 > Project: Kylin > Issue Type: Bug > Reporter: weibin0516 > Assignee: weibin0516 > Priority: Major > Fix For: v3.1.0, v3.0.2 > > Attachments: image-2020-01-13-23-20-23-476.png > > > In kylin.properties, > {code:java} > kylin.engine.spark-fact-distinct=true > {code} > !image-2020-01-13-23-20-23-476.png! > set this config to false in cube, but not effective when build cube -- This message was sent by Atlassian Jira (v8.20.10#820010)
