[
https://issues.apache.org/jira/browse/KYLIN-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070176#comment-18070176
] ASF GitHub Bot commented on KYLIN-4030: --------------------------------------- codecov-commenter commented on PR #673: URL: https://github.com/apache/kylin/pull/673#issuecomment-4166490881 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `50.00000%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 25.79%. Comparing base ([`354f6de`](https://app.codecov.io/gh/apache/kylin/commit/354f6ded8506fa53b4a78a8614da1e1c2bf1fef2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2dec22e`](https://app.codecov.io/gh/apache/kylin/commit/2dec22e1e9ad8035e8ce08c7edf6cc113e869b8c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/673?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...he/kylin/common/persistence/HDFSResourceStore.java](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9IREZTUmVzb3VyY2VTdG9yZS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/kylin/common/persistence/JDBCResourceStore.java](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCResourceStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VTdG9yZS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/kylin/storage/hbase/HBaseResourceStore.java](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&filepath=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseResourceStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZVJlc291cmNlU3RvcmUuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/kylin/common/persistence/ResourceStore.java](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FResourceStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #673 +/- ## ============================================ + Coverage 25.77% 25.79% +0.01% Complexity 6009 6009 ============================================ Files 1382 1382 Lines 82194 82204 +10 Branches 11516 11518 +2 ============================================ + Hits 21187 21203 +16 + Misses 58956 58953 -3 + Partials 2051 2048 -3 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/673?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > ResourceStore deleteResource by comparing timestamp may be failed to delete > caused by time precision loose > ---------------------------------------------------------------------------------------------------------- > > Key: KYLIN-4030 > URL: https://issues.apache.org/jira/browse/KYLIN-4030 > Project: Kylin > Issue Type: Bug > Reporter: PENG Zhengshuai > Assignee: PENG Zhengshuai > Priority: Minor > Fix For: v2.6.3 > > > In ResourceStore, the interface *deleteResourceImpl(String resPath, long > timestamp)* maybe failed to delete the resource because the resource > timestamp may lose the precision. > For example, if we use *$KYLIN_HOME/bin/metastore.sh* to backup from > metastore to Local OS filesystem, and restore from local filesystem to > metastore. The resource timestamp will lose precision in Millis Second. > An example here: > original timestamp: 1559564381 > after precision lost: 1559564000 > The fix design is to tolerate [0-999] ms difference when comparing the > timestamp -- This message was sent by Atlassian Jira (v8.20.10#820010)
