[
https://issues.apache.org/jira/browse/KYLIN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069854#comment-18069854
]
ASF GitHub Bot commented on KYLIN-4855:
---------------------------------------
codecov-commenter commented on PR #1536:
URL: https://github.com/apache/kylin/pull/1536#issuecomment-4161248402
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/1536?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 25.41%. Comparing base
([`5c12d08`](https://app.codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`be98fd8`](https://app.codecov.io/gh/apache/kylin/commit/be98fd854f83579cff84591f4e683fce682fd7ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1536 +/- ##
============================================
- Coverage 25.43% 25.41% -0.02%
+ Complexity 6767 6763 -4
============================================
Files 1508 1508
Lines 93918 93918
Branches 13158 13158
============================================
- Hits 23890 23872 -18
- Misses 67653 67664 +11
- Partials 2375 2382 +7
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/1536?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> kylin metrics prefix bug in system-cube.sh
> ------------------------------------------
>
> Key: KYLIN-4855
> URL: https://issues.apache.org/jira/browse/KYLIN-4855
> Project: Kylin
> Issue Type: Bug
> Components: Environment
> Affects Versions: v2.6.0
> Environment: 2.6.0+
> Reporter: Huajie Wang
> Assignee: Huajie Wang
> Priority: Minor
> Labels: easyfix
> Fix For: v3.1.2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> After executed "system-cube.sh cron", the system cube will be added to the
> crontab, but the cube name is wrong, and it does not match the actual
> situation. After testing, it is found that the system-cube is
> There is a bug in the handling of kylin metrics prefix
> In the system-cube.sh script, the prefix is "KYLIN". The logic is wrong. You
> should get "kylin.metrics.prefix" from kylin.properties. If this item is set,
> take the value set by the user, if not set, go to the default value. "KYLIN"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
