Csaba Ringhofer created IMPALA-14985:
----------------------------------------
Summary: Cleanup tests with unused 'vector' in EE tests
Key: IMPALA-14985
URL: https://issues.apache.org/jira/browse/IMPALA-14985
Project: IMPALA
Issue Type: Improvement
Components: Test
Reporter: Csaba Ringhofer
example:
https://github.com/apache/impala/blob/53f5d74b9c905aad36c54f9251e0d25fc21d80bc/tests/catalog_service/test_large_num_partitions.py#L36
test_list_partitions() has a vector argument, leading to potentially running it
with multiple parameters, but actually the vector is not used so my
understanding is that the all test runs will work the same
the effect of vector can be misleading - for example the query options are not
passed to default client, but CLIENT_IDENTIFIER query option is actually
modified with a string containing all parameters in the vector, suggesting
different query options (like disable_codegen)
example:
{code}
Query Options (set by configuration):
TIMEZONE=Europe/Budapest,CLIENT_IDENTIFIER=query_test/test_avro_schema_resolution.py::TestAvroSchemaResolution::test_avro_c_lib_unicode_nulls["table_format:avro/snap/block"|"protocol:hs2"|"exec_option:{'abort_on_error':1;'batch_size':0;'disable_codegen':True;'disable_codegen_rows_threshold':0;'
{code}
disable_codegen:true suggest no codegen, but actually a the query
TestAvroSchemaResolution::test_avro_c_lib_unicode_nulls runs with codegen
enabled
--
This message was sent by Atlassian Jira
(v8.20.10#820010)