nastra commented on code in PR #7988:
URL: https://github.com/apache/iceberg/pull/7988#discussion_r1259861778
##########
delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:
##########
@@ -532,13 +533,14 @@ private void addExternalDatafiles(
private static String getFullFilePath(String path, String tableRoot) {
URI dataFileUri = URI.create(path);
try {
- String decodedPath = new URLCodec().decode(path);
+ String decodedPath = URLDecoder.decode(path,
StandardCharsets.UTF_8.name());
if (dataFileUri.isAbsolute()) {
return decodedPath;
} else {
return tableRoot + File.separator + decodedPath;
}
- } catch (DecoderException e) {
+ } catch (UnsupportedEncodingException e) {
+ // In Java 10+ this will not need try-catch
Review Comment:
is that comment relevant? I think we can probably remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
