nastra commented on code in PR #7992:
URL: https://github.com/apache/iceberg/pull/7992#discussion_r1259292615
##########
api/src/main/java/org/apache/iceberg/view/ViewBuilder.java:
##########
@@ -18,18 +18,16 @@
*/
package org.apache.iceberg.view;
-import java.util.List;
import java.util.Map;
import org.apache.iceberg.Schema;
-import org.apache.iceberg.catalog.Namespace;
import org.apache.iceberg.catalog.ViewCatalog;
/**
* A builder used to create or replace a SQL {@link View}.
*
* <p>Call {@link ViewCatalog#buildView} to create a new builder.
*/
-public interface ViewBuilder {
+public interface ViewBuilder extends VersionBuilder<ViewBuilder> {
Review Comment:
At this point I'm not entirely sure whether we'd need to have a
`withLocation()` method here. Should we wait until we get to
https://github.com/apache/iceberg/pull/7913 and we can re-evaluate and add it
when necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
