szehon-ho commented on code in PR #7920:
URL: https://github.com/apache/iceberg/pull/7920#discussion_r1254764480
##########
spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1469,12 +1483,20 @@ public void testPartitionsTableLastUpdatedSnapshot() {
new GenericRecordBuilder(
AvroSchemaUtil.convert(
partitionsTable.schema().findType("partition").asStructType(),
"partition"));
+
+ List<DataFile> dataFilesFromFirstCommit = listDataFilesFromCommitId(table,
firstCommitId);
Review Comment:
Would it work to make a method List<DataFile> dataFiles(table) to get all
the data files, so we don't have to do add data files from both commits?
I did this before here:
https://github.com/apache/iceberg/blob/master/spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java#L682
(maybe we can do it without column stats here).
If we do this, we can even extract to TestHelpers in a later PR.
##########
spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1469,12 +1483,20 @@ public void testPartitionsTableLastUpdatedSnapshot() {
new GenericRecordBuilder(
AvroSchemaUtil.convert(
partitionsTable.schema().findType("partition").asStructType(),
"partition"));
+
+ List<DataFile> dataFilesFromFirstCommit = listDataFilesFromCommitId(table,
firstCommitId);
Review Comment:
Would it work to make a method List<DataFile> dataFiles(table) to get all
the data files, so we don't have to do add data files from both commits?
I did this before here:
https://github.com/apache/iceberg/blob/master/spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java#L682
(maybe we can do it without column stats here, to be shorter).
If we do this, we can even extract to TestHelpers in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
